182 waterfall footer #193
Merged
182 waterfall footer #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReehalS
had a problem deploying
to
development
GitHub Actions
Failure
Member
Author
|
Also no mobile view for waterfall yet (entire component just disappears for anything under a lg screen) |
ReehalS
had a problem deploying
to
development
GitHub Actions
Failure
Member
Author
|
Waterfall mobile component done, still needs fixing for the xs and 2xs sizes which don't seem to be working right now |
Closed
JayJ104
requested changes
Feb 24, 2025
Contributor
JayJ104
left a comment
JayJ104
left a comment
There was a problem hiding this comment.
- missing the background behind the ducky in mobile view
- ducky be floating from 390-640px (see image below). until the xs, 2xs issue is fixed, can you fix it without breakpoints?
Member
Author
|
Background behind ducky will come from the Vinyl component so I'll add that when I do vinyl. I'll probably just move the ducky into vinyl instead of have the the waterfall component exist in screens under lg size |
ReehalS
had a problem deploying
to
development
GitHub Actions
Failure
ReehalS
had a problem deploying
to
development
GitHub Actions
Failure
ReehalS
had a problem deploying
to
development
GitHub Actions
Failure
JayJ104
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #182
Currently the icons for the footer aren't turning white (maybe something to do with the tailwind config), but apart from that everything works