Prevents setLoading(false) on nullish hook input #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayJ104
approved these changes
Apr 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We have hooks that have inputs that depend on the results of other hooks, like our auth state for example. Our auth state (user) might have an undefined user_id if we are querying it early. Now, this undefined value might get passed in as an initializer value for one of our own user defined hooks such as getSubmissions. Then, it'll run through the fetchSubmissions function with the bad input, then setLoading(false). When loading is false, the frontend will assume that the data is ready to read (that's the paradigm we've been using) so the frontend will try to do data manipulation on smth that isn't ready. However, soon the auth state will finish loading and real data will get passed in, hence the quick flash of error that fixes itself.