Skip to content
This repository was archived by the owner on Oct 12, 2025. It is now read-only.

Conversation

@yashjagtap23
Copy link
Contributor

@yashjagtap23 yashjagtap23 commented Dec 11, 2024

Description

Fixes #598

  • fixed error popup even when QR code was successfully scanned in back end

Todos

  • can still be more specific about error messages
  • Possibly close QR code scanner if QR code / event is expired

Screenshots

giphy

removed error descriptions for now to simplify. Error seems to be due to missing field in event.swift for boolean success
Copy link
Contributor

@anushkasankaran anushkasankaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@yashjagtap23 yashjagtap23 merged commit 3bfd717 into dev Dec 11, 2024
2 checks passed
@yashjagtap23 yashjagtap23 deleted the Yash/random-branch branch December 11, 2024 19:35
@akulsharma1
Copy link

u broke the app dude

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Staff Attendance QR Scanning

4 participants