Skip to content
This repository was archived by the owner on Oct 12, 2025. It is now read-only.

Event Location and Map Caching Fix #634

Merged
anushkasankaran merged 4 commits into from
Feb 23, 2025
Merged

Event Location and Map Caching Fix #634

anushkasankaran merged 4 commits into from
Feb 23, 2025

Conversation

@nathannwangg
Copy link
Contributor

@nathannwangg nathannwangg commented Feb 23, 2025 •
edited
Loading

Description

  • Added self.mapview.image = nil before the if let mapUrl = URL(string: imageUrlString) check in HIEventDetailViewController.swift
  • Changed coreDataEvent.addToLocations(coreDataLocation) to replace, not append, by adding coreDataEvent.removeFromLocations(coreDataLocation) before it in HIEventDataSource.swift

@nathannwangg
set self.mapView.image to nil before the if let mapUrl = URL(string: …
d7cb184 
…imageUrlString) check in HIEventDetailViewController.swift. Added coreDataEvent.removeFromLocations before coreDataEvent.addToLocations in HIEventDataSource.swift
@anushkasankaran anushkasankaran merged commit 2c9e96e into dev Feb 23, 2025
2 checks passed
@anushkasankaran anushkasankaran deleted the caching-fix branch February 23, 2025 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lasyaneti lasyaneti Awaiting requested review from lasyaneti

@s0phialiu s0phialiu Awaiting requested review from s0phialiu

@AydanPirani AydanPirani Awaiting requested review from AydanPirani AydanPirani is a code owner

@Timothy-Gonzalez Timothy-Gonzalez Awaiting requested review from Timothy-Gonzalez Timothy-Gonzalez is a code owner

1 more reviewer

@anushkasankaran anushkasankaran anushkasankaran approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nathannwangg @anushkasankaran