user can choose school not listed for registration #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Shreepaad
commented
Dec 12, 2025
Shreepaad
commented
- user can choose school not listed for registration
added ability for user to choose a school not listed
✅ Deploy Preview for hackillinois ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
A few suggestions:
- Saved school name issue on backend
On autosave, the school saves as what the user typed in (which is what we want):
When the user submits, it saves as "Other - Not Listed":
This is because the call to submitDraft in app/register/general/page.tsx (Line 303) sends what's in formik.values, so school is sent as other not listed.
- I recommend adding some text below the School field indicating to the user to select "Other - not listed" if their school isn't present. This is so that if they search for their school and don't find it, they immediately know what to do next.
I'd copy the style of the text under the age field:
miguelaenlle
approved these changes
Dec 13, 2025
Contributor
miguelaenlle
left a comment
miguelaenlle
left a comment
There was a problem hiding this comment.
The fix worked for storing other/non-specified school names 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.