CI/CD ARM 러너 전환 및 Compose 설정 로딩 안정화#200
Conversation
📝 Walkthrough개요CI/CD 워크플로우 설정 변경과 Docker Compose 환경 설정 변경을 포함합니다. 워크플로우는 Ubuntu 러너 업데이트, 태그 변경, 불필요한 단계 제거를 포함합니다. Docker Compose는 Spring 프로필 설정 형식이 변경되고 추가 설정 파일 위치가 추가되었습니다. 변경 사항
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 CI/CD 파이프라인의 효율성과 안정성을 개선하고, 애플리케이션 배포 환경 설정을 유연하게 관리하기 위한 변경 사항을 포함합니다. 도커 이미지 빌드 환경을 실제 배포 타깃과 일치시켜 아키텍처 불일치 문제를 줄이고, 빌드 워크플로우를 간소화했습니다. 또한, 도커 컴포즈 환경 변수 관리 방식을 개선하여 프로필별 설정 파일을 동적으로 로드할 수 있도록 함으로써, 다양한 환경에서 애플리케이션을 일관되게 운영할 수 있는 기반을 마련했습니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ec0774930
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
.github/workflows/gradle.yml (1)
61-61: 변수명과 값의 의미를 맞추면 읽기 비용이 줄어듭니다.Line 61은 값이
latest인데 변수명이DEV_TAG라 의도가 헷갈립니다.LATEST_TAG로 맞추는 걸 권장합니다.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/gradle.yml at line 61, The variable DEV_TAG is misleading because its value is "latest"; rename the variable to LATEST_TAG and update all references in the workflow to use LATEST_TAG (replace occurrences of DEV_TAG in the gradle.yml actions/steps and any env or shell interpolation). Ensure any downstream steps, expressions, or matrix entries that previously read DEV_TAG are updated and that the variable name change preserves the same value ("latest") and behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/gradle.yml:
- Line 90: 워크플로우 이름 "Trigger Jenkins Deploy (dev)"와 실행 조건(브랜치 필터: main)이 불일치합니다;
.github/workflows/gradle.yml에서 워크플로우 name 필드("Trigger Jenkins Deploy (dev)") 또는
트리거 조건(현재 main으로만 실행되도록 설정된 브랜치 필터)을 일치시키도록 수정하세요 — 즉 dev 배포로 의도했다면 브랜치 조건을 dev로
변경하거나, main에서 실행할 의도라면 name을 "Trigger Jenkins Deploy (main)" 등으로 변경하여 혼란을 제거하세요.
In `@docker-compose.yml`:
- Around line 8-9: The environment variable key and value format are wrong so
Spring Boot profiles aren't loaded: replace the hyphenated key
SPRING_CONFIG_ADDITIONAL-LOCATION with SPRING_CONFIG_ADDITIONALLOCATION, remove
the surrounding quotes from the value, and ensure the default profile is used in
the path (use ${ACTIVE_PROFILE:-dev} for both SPRING_PROFILES_ACTIVE and inside
the config path) — alternatively convert the environment list to a YAML map
under the service's environment block (e.g., SPRING_PROFILES_ACTIVE:
${ACTIVE_PROFILE:-dev} and SPRING_CONFIG_ADDITIONALLOCATION:
file:/config/application-${ACTIVE_PROFILE:-dev}.yml) to avoid Docker Compose
quoting/list issues.
---
Nitpick comments:
In @.github/workflows/gradle.yml:
- Line 61: The variable DEV_TAG is misleading because its value is "latest";
rename the variable to LATEST_TAG and update all references in the workflow to
use LATEST_TAG (replace occurrences of DEV_TAG in the gradle.yml actions/steps
and any env or shell interpolation). Ensure any downstream steps, expressions,
or matrix entries that previously read DEV_TAG are updated and that the variable
name change preserves the same value ("latest") and behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 37b66261-0f1b-4c17-b8a4-3515234d2145
📒 Files selected for processing (2)
.github/workflows/gradle.ymldocker-compose.yml
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to transition the CI/CD Docker build runner to ARM and refine Docker Compose environment variables. However, a critical misconfiguration was found in docker-compose.yml: a hyphen was used in an environment variable name instead of an underscore. This prevents Spring Boot from loading additional configuration files, potentially leaving the application in an insecure state by falling back to default development settings. Addressing this will ensure proper separation of environment-specific configurations.
zionhann
changed the title
zionhann
changed the title
zionhann
changed the title
1 participant
GitHub Actions 도커 빌드 잡을 ARM 러너 기준으로 단순화하고 이미지 태그를
latest로 정리docker-compose 환경 변수 키/값 형식을 Spring 규칙에 맞게 정정하고 프로필 기본값을 일치