Skip to content

fix: correct filter conditions to use strict inequalities#90

Draft
tobiasploetz wants to merge 1 commit into
HannesStark:mainfrom
tobiasploetz:fix/filter-condition
Draft

fix: correct filter conditions to use strict inequalities#90
tobiasploetz wants to merge 1 commit into
HannesStark:mainfrom
tobiasploetz:fix/filter-condition

Conversation

@tobiasploetz
Copy link
Copy Markdown

Such that the actual filtering aligns with filter definitions, e.g.

--additional_filters 'ALA_fraction<0.3' 'filter_rmsd_design<2.5'

@tobiasploetz tobiasploetz marked this pull request as draft November 28, 2025 08:50
@tobiasploetz
Copy link
Copy Markdown
Author

I think this breaks some existing filters that assume >= and <= to be used. A better way forward would be to add an equality flag to the filter dictionaries, and let users also define additional filters like metric<=threshold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant