Skip to content

Here is my circuit widget#10

Open
sassil1 wants to merge 6 commits into
Harvard-Westlake:mainfrom
sassil1:Sydney-Circuit+Resistors
Open

Here is my circuit widget#10
sassil1 wants to merge 6 commits into
Harvard-Westlake:mainfrom
sassil1:Sydney-Circuit+Resistors

Conversation

@sassil1

@sassil1 sassil1 commented Nov 11, 2025

Copy link
Copy Markdown

No description provided.

@hwdbaek77 hwdbaek77 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.google.com/document/d/1eBJChRhmLIlftaG19loCRExLezHg_9YXi4ZRFlmets0/edit?usp=sharing

1 Functions

Does the app do what it claims (happy paths)?

Yes, it visualizes for the user a circuit with resistors that displays both resistors in series and in parallel. The relative strength of the lightbulb is supposed to reflect how much power is going to it.

Suggestion 1: There are some rendering errors when constructing more complex circuits (attached) which means there are some floating resistors and lightbulbs.

Suggestion 2: The lightbulb strength being yellow on a white background is sometimes very hard to make out at a low voltage. I would make it a slightly more contrasting color

Suggestion 3:

Sometimes the window behavior is inconsistent, as in it either pops up below the circuit or above the circuit. It could be helpful for more complex circuits having the box entirely separate from the circuit and just displaying the stats when you click on it.

Is the behavior correct per docs/specs (research if unsure)?

Yes, all the equations and math seem correct.

Any console/network/server errors on load or when using widgets?

2 User

Is the UX engaging and responsive?

Yes, the ux is simple to work around.

Suggestion 1: When selecting multiple resistors, the popup to display resistance, voltage, current, and power sometimes covers either the resistor or light bulb behind it (attached). I would suggest when displaying the window it pops up slightly further away from the resistor or bulb so it doesn’t cover it.

Is the UI intuitive (labels, flows, empty/error states)?

The UI is simple and pretty compact which means it’s easy to navigate around and find what you need to do. There are no errors on load

Suggestion 1: When adding resistors, the page prematurely adds like a billion blank space to the bottom of the webpage, which you can scroll down infinitely

Does the UI match the /admin learn.hw.com page design/theme?

No, right now everything that’s an accent is in blue. I think the font is correct but everything else is not reflected correctly.

Daniel Baek added 2 commits November 20, 2025 09:00
Updates the circuit UI to a more modern style and Harvard-Westlake branding.

Introduces functionality to dynamically add and remove resistors and bulbs in series or parallel configurations.

Improves selection handling with a centralized selection panel for component details.

Removes the initial R1/R2 components and associated info cards.
Enhances the clarity of component statistics by using more descriptive labels.

Ensures consistent SVG height scaling by using a base height ratio. This prevents compounding scaling issues as the circuit grows.
@hwdbaek77

Copy link
Copy Markdown

https://docs.google.com/document/d/1eBJChRhmLIlftaG19loCRExLezHg_9YXi4ZRFlmets0/edit?usp=sharing
1 Functions

Suggestion 1: There are some rendering errors when constructing more complex circuits (attached) which means there are some floating resistors and lightbulbs.

Fix 1: Adjusted the layout math for parallel branches so that series chains within parallel groups are guaranteed to fit between their bus bars and always have wires drawn from bus to component to bus. Should get rid of floating resistors.

Suggestion 2: The lightbulb strength being yellow on a white background is sometimes very hard to make out at a low voltage. I would make it a slightly more contrasting color

Fix 2: Base low-power color: #FFD45A → ramps to #FF8C00 at higher power

Suggestion 3: Sometimes the window behavior is inconsistent, as in it either pops up below the circuit or above the circuit. It could be helpful for more complex circuits having the box entirely separate from the circuit and just displaying the stats when you click on it.

Fix 3: Replaced inconsistent floating SVG popups with a dedicated selection panel below the readouts that better displays selected components and stats in a fixed location. Also added numbered red badges on both the circuit diagram and in the panel rows so that you can match which resistor corresponds to which stats when multiple components are selected.

2 User

Suggestion 1: When adding resistors, the page prematurely adds like a billion blank space to the bottom of the webpage, which you can scroll down infinitely

Fix 1: Fixed it by stopping the runaway SVG height growth so now it uses a stable base ratio to compute the height so adding resistors increases canvas size linearly instead of compounding into infinite scroll

Suggestion 2: Add mobile support

Fix 2: Added mobile support

Suggestion 3: No, right now everything that’s an accent is in blue. I think the font is correct but everything else is not reflected correctly.

Fix 3: Fixed to reflect admin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants