Skip to content

Implemented my widget#7

Open
mmeyer1s wants to merge 5 commits into
Harvard-Westlake:mainfrom
mmeyer1s:implementgaussiansurfaces
Open

Implemented my widget#7
mmeyer1s wants to merge 5 commits into
Harvard-Westlake:mainfrom
mmeyer1s:implementgaussiansurfaces

Conversation

@mmeyer1s
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@jreiner16 jreiner16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot of text to read through. It doesn't feel like a widget, it feels more like a pdf lesson document. I would suggest adding more interactive things higher up.

There are errors/warnings in the console, mostly WARN: unrecognized GUI edit. there is also [Intervention], maybe more frequent in mobile.

The plotly UI is too busy. There is too much junk, why would I need a box/lasso select?

The 3d visualizations are pretty good. I like the navigation. However in mobile there is a "q" and "e" button which is kinda weird -- why would I want to be clicking a keyboard button on my phone? maybe add mobile-specific navigation.

There are a few variables declared that are never used from what I can tell, ask cursor to find them an remove them.

It takes a long time to load. maybe use buffered loading.

Some windows have rounded corners but some have square corners

Some of the writing absolutely reeks of AI

the "double click to zoom back out" message looks a little out of place

overall its really good. i can't understand most of this stuff but i think it probably makes sense and would be a good way to explain this stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants