Modifies DNA_DELIMITER to * #752
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddalbert
approved these changes
Mar 8, 2022
Jonas-Lieske
pushed a commit
to Jonas-Lieske/hashlips_art_engine
that referenced
this pull request
Apr 21, 2022
As suggested in HashLips#752
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-is a very common character to use when naming files. Restricting filenames to not include-seems odd. I expect a lot of users would want metadata with attributes with a dash, like V-Neck, Hi-Vis, etc.This PR modifies the
DNA_DELIMITERto*which is a far less common used character in filenames.Also updated when we should throw an error, which should only be if a filename has the
DNA_DELIMITER.Tested and I am able to run my generator just fine.