-
Notifications
You must be signed in to change notification settings - Fork 483
Use scrollRect to clip filters and position game window #3487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -325,8 +325,6 @@ class FlxDebugger extends openfl.display.Sprite | |
resetButtonLayout(); | ||
resetLayout(); | ||
scaleX = scaleY = scale; | ||
x = -FlxG.scaleMode.offset.x; | ||
y = -FlxG.scaleMode.offset.y; | ||
Comment on lines
-328
to
-329
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also this needs to be reverted for my change in #3487 (comment), otherwise a portion of the debugger will be off screen |
||
} | ||
|
||
function updateBounds():Void | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure what you meant by "figure out why resizing the window messes this up" but when testing this, I noticed that the sound tray and mouse were offset. Replacing this block with: FlxG.game.x = offset.x;
FlxG.game.y = offset.y;
final rect = FlxG.game.filteredContainer.scrollRect;
rect.setTo(0, 0, gameSize.x, gameSize.y);
FlxG.game.filteredContainer.scrollRect = rect; seemed to fix things for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it say
use inputContainer
instead of justuse
?That way users would know the new variable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol yep