Prevent closing socket handle twice #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the socket handle has been closed once, it no longer belongs to us and it is unsafe to close it again as it could have been assigned somewhere else in the program. On android for example, this is detected at runtime by fdsan and causes a hard crash. We could also consider throwing an error on the second close, however, for now this is already a step forward.
tobil4sk
force-pushed
the
fix/prevent-socket-double-close
branch
from
d1e626b to
5828abd
Compare
charlesisfeline
pushed a commit
to charlesisfeline/hxcpp
that referenced
this pull request
Mar 26, 2025
If the socket handle has been closed once, it no longer belongs to us and it is unsafe to close it again as it could have been assigned somewhere else in the program. On android for example, this is detected at runtime by fdsan and causes a hard crash. We could also consider throwing an error on the second close, however, for now this is already a step forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the socket handle has been closed once, it no longer belongs to us and it is unsafe to close it again as it could have been assigned somewhere else in the program. On android for example, this is detected at runtime by fdsan and causes a hard crash.
We could also consider throwing an error on the second close, however, for now this is already a step forward.