Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for item ids being required to be unique across all collections #26

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Fix for item ids being required to be unique across all collections #26

merged 5 commits into from
Jul 22, 2024

Conversation

pedro-cf
Copy link
Collaborator

@pedro-cf pedro-cf commented Jul 17, 2024 •
edited
Loading

Related Issue(s):

Description:
Added a new index based on collection id and item id to ensure item IDs aren't required to be unique across all collections.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

@pedro-cf pedro-cf requested a review from jonhealy1 July 17, 2024 21:36
@jonhealy1
Copy link
Contributor

@pedro-cf Should we create a test for this to make sure it will work as expected?

@pedro-cf
Copy link
Collaborator Author

@pedro-cf Should we create a test for this to make sure it will work as expected?

Greetings, made a test and fixed a bug 👍

Needed to fix up sync_prep_create_item and prep_create_item in database_logic

jonhealy1
jonhealy1 requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Pedro. Just one question.

@jonhealy1 jonhealy1 self-requested a review July 22, 2024 22:32
@jonhealy1 jonhealy1 merged commit a4e766c into main Jul 22, 2024
5 checks passed
@jonhealy1 jonhealy1 deleted the index_fix branch July 22, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhealy1 jonhealy1 jonhealy1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedro-cf @jonhealy1