test(vault): cover admin-setter success paths and getter coverage gaps (#428-431)

[chonilius]

Summary

Adds the missing success-path test coverage flagged in #428, #429, #430, and #431 — four investment_vault entry points that either had only their #[only_owner] admin-rejection path exercised, or (for the two getters) no coverage at all.

• set_bridge() / set_wormhole_core() (investment_vault: set_bridge() and set_wormhole_core() are never called successfully in any test — only their admin-rejection path is covered #428): new tests call each as owner, confirm the address round-trips through contract storage, confirm set_bridge's BridgeSet event fires on the first call, and confirm the no-op-if-unchanged early return (lib.rs:1247-1250) skips emitting a second event on a repeat call with the same address.
• set_carbon_oracle() / set_max_transaction_amount() (investment_vault: set_carbon_oracle() and set_max_transaction_amount() are never called successfully in any test — only their admin-rejection path is covered #429): same persist + event + no-op-early-return shape.
• get_deposit_lock_expiry() (investment_vault: get_deposit_lock_expiry() has zero test coverage #430): asserts it returns 0 for a fresh account and deposited_at + MIN_LOCK_PERIOD immediately after a deposit.
• is_funding_round_active() (investment_vault: is_funding_round_active() getter has zero direct test coverage #431): asserts false initially, true after start_funding_round, false again after end_funding_round.

Why this touches more than test.rs

investment_vault did not compile from a clean checkout of main — the crate has several pre-existing merge-corruption bugs unrelated to these issues that had to be fixed before any test (old or new) could even run:

• check_deposit_lock() had a stray, undefined-variable (last_seq) sequence-number check spliced into the middle of its body with mismatched braces. Restored it to the single timestamp-based MIN_LOCK_PERIOD check its own doc comment ([Logic] Implement share lock-up period after deposit #33) describes.
• get_withdrawal_window() and get_volume_fee_tier() in lib.rs, and withdrawal_window_set() / funding_round_ended() in events.rs, were each missing their closing brace, silently merging their bodies into the next function.
• VaultError::EmptyBatchDeposit, FundingRoundActive, and InvestmentCapExceeded all shared discriminant 41 (E0081). Reassigned FundingRoundActive = 42 and InvestmentCapExceeded = 43 — nothing depends on their specific numeric values.

Fixing check_deposit_lock() means the deposit lock is now genuinely enforced during tests (previously it could not run at all), which surfaced a few more pre-existing issues blocking the suite from running:

• test_get_project_investments_batch_returns_correct_amounts and test_claim_queued_is_idempotent_against_double_claim were calling registry_contract::create_project() with a stale 6-argument signature; updated to the current 4-argument (creator, uri, maturity_date, metadata_hash) signature.
• test_get_all_project_investments_returns_all had entirely lost its body (with unrelated, otherwise-complete tests spliced into the gap) — reconstructed a minimal body matching its name.
• The real body belonging to that same corrupted region turned out to be an orphaned, unnamed block testing queued-claim double-payout protection — recovered it as test_claim_settles_queued_withdrawal_then_second_claim_is_noop and advanced its ledger timestamp past MIN_LOCK_PERIOD before withdrawing, now that the lock is enforced.
• test_get_deposit_lock_expiry (this PR's own new test) needed a non-zero ledger timestamp before depositing, since the getter's own "0 means never deposited" sentinel is otherwise indistinguishable from a real deposit made at the test env's default timestamp of 0.

Test plan

• cargo test -p investment-vault --lib — full suite compiles and runs (previously failed to compile at all)
• All 4 issue-specific tests pass: test_set_bridge_persists_emits_event_and_is_idempotent, test_set_wormhole_core_persists, test_set_carbon_oracle_persists_emits_event_and_is_idempotent, test_set_max_transaction_amount_persists_emits_event_and_is_idempotent, test_get_deposit_lock_expiry, test_is_funding_round_active_reflects_start_and_end
• All tests touched by the compile fixes pass: test_get_all_project_investments_returns_all, test_get_project_investments_batch_returns_correct_amounts, test_claim_queued_is_idempotent_against_double_claim, test_claim_settles_queued_withdrawal_then_second_claim_is_noop, test_get_set_withdrawal_window, test_volume_fee_tier_is_admin_only

Closes #428
Closes #429
Closes #430
Closes #431

[drips-wave]

@chonilius Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits