Skip to content

fix(hql): compilation error for AddE with borrowed IDs in FOR loops #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
+9 −5
Closed

fix(hql): compilation error for AddE with borrowed IDs in FOR loops #667

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95e1a17
fix(hql): compilation error for AddE with borrowed IDs in FOR loops
ishaksebsib Oct 21, 2025
c988839
revert(hql): Change AddE ID accessor back to .id()
ishaksebsib Oct 26, 2025
a98d802
feat(hql): Add .id() method to ID struct for unified accessor interface
ishaksebsib Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions helix-db/src/utils/id.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ impl ID {
self.0
}

pub fn id(&self) -> u128 {
self.0
}

pub fn stringify(&self) -> String {
uuid::Uuid::from_u128(self.0).to_string()
}
Expand Down Expand Up @@ -117,14 +121,12 @@ pub fn v6_uuid() -> u128 {
uuid::Uuid::now_v6(&[1, 2, 3, 4, 5, 6]).as_u128()
}


#[cfg(test)]
mod tests {
use sonic_rs::json;

use super::*;


#[test]
fn test_uuid_deserialization() {
let uuid = json!({ "id": "1f07ae4b-e354-6660-b5f0-fd3ce8bc4b49" });
Expand All @@ -134,9 +136,11 @@ mod tests {
id: ID,
}


let deserialized: IDWrapper = sonic_rs::from_value(&uuid).unwrap();
assert_eq!(deserialized.id.stringify(), "1f07ae4b-e354-6660-b5f0-fd3ce8bc4b49");
assert_eq!(
deserialized.id.stringify(),
"1f07ae4b-e354-6660-b5f0-fd3ce8bc4b49"
);
}

#[test]
Expand All @@ -151,4 +155,4 @@ mod tests {

assert_eq!(uuid.to_string(), "1f07ae4b-e354-6660-b5f0-fd3ce8bc4b49");
}
}
}
Loading