-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add nexo support #161
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't just bump the java version by 10 releases to add support for a plugin. This needs to be announced first.
Yes, this PR is more to let HelpChat know that if they want to support Nexo, they'll have to update to Java 21, as well as add the hook itself so that if anyone wants to compile it themselves, they can. Other plugins that have added Nexo support have marked their Oraxen support as Deprecated, such as CrazyCrates and HMCCosmetics. |
Any news on this? |
I've been told a version of the Nexo API that doesn't require Java 21 is potentially being worked on. Will update this if that ever comes out. |
Hi! So yeah, I can understand this change requires an announcement, but it only affects a minority of servers, especially since the servers using a version lower than Java 21, they are also using an old version of DeluxeMenus ^-^
|
Also looking for Nexo support in DeluxeMenus - Don't most modern server wrappers prefer Java 21 at this point? |
The change of the version would "only" affect a minority, but that is still a whopping 40% of users. In this case you can use |
I have created this pull request that adds Nexo support to DeluxeMenus (#155). I have tested this on my development server and have not encountered any issues. The implementation is nearly identical to the existing Oraxen hook.
Some things to note: