Add support for ESP32-S3 4-Inch LCD display.#20
Open
Solaniel wants to merge 1 commit into
Open
Conversation
Owner
|
Hey thanks for your contribution! Here's a bit of an update: I held off on merging any alternative hardware ports because I wanted a good abstraction layer for that. Then @tobby168 came in clutch and delivered that in #25 with instructions in the We include detailed instructions now which hopefully would allow your clanker to refactor your PR to conform with the new standard, thank you for your patience! P.S. if you can post a picture of your port that would be appreciated, I enjoy seeing how it looks on people's devices! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Waveshare ESP32-S3-Touch-LCD-4 support
Adds multi-board support so the same codebase compiles and runs on both the Waveshare ESP32-S3-Touch-AMOLED-2.16 (original target) and the Waveshare ESP32-S3-Touch-LCD-4 (4" 480×480 RGB LCD). All board-specific code is gated with #ifdef
BOARD_WAVESHARE_LCD4 / #else so the AMOLED build is unaffected.
Changes
firmware/platformio.ini
firmware/src/display_cfg.h
firmware/src/main.cpp
firmware/src/power.cpp
firmware/src/imu.cpp
flash-mac.sh
Test plan:
Tested on an ESP32-S3 4" LCD Display board on a Macbook Pro 2022 M3: