Removed validation for test persons#44
Draft
HermannBjorgvin wants to merge 2 commits into
Draft
Conversation
eirikurn
reviewed
Mar 15, 2025
|
|
||
| export const isValid = ( | ||
| kennitala: string, | ||
| options?: ValidationOptions |
Collaborator
There was a problem hiding this comment.
This is a breaking change to the TypeScript definition. Wonder if we should just deprecate and ignore options or bump to v4?
Owner
Author
There was a problem hiding this comment.
Yeah might be good to patch v3 since it's been available for a while now. Will change this to a patch vs major and v4 can be a separate PR
Owner
Author
There was a problem hiding this comment.
Opened another pr #45
Will publish 3.0.4 with the Misc suggestions PR and that one.
HermannBjorgvin
marked this pull request as draft
March 17, 2025 08:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since real persons with 0 or 1 as 7th char exist as edge cases I am removing validation for test persons.
And since the person with a KT like that can be valid then test persons will also always be valid, so no need to add an option to allow the test dataset