[ENHANCEMENT] Added optional comparator property to handle complex value #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember
findBy
method compare by identity and that's good for primitive values, but when we deal with objects identity could not be the perfect solution.For example, 2 different
Date
objects referring both to today are!==
, however are equals conceptually.To handle this I've added a comparator property that works like this
Hope this gets merged, cause I think there're many use case where this could be useful.
P.S. I've also updated the ember-cli version and added test