Skip to content

[REF/#633] Replace EmojiFilter with String extensions #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angryPodo merged 2 commits into from
Feb 13, 2026
Merged

[REF/#633] Replace EmojiFilter with String extensions #689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09ead11
refactor: move emoji filter to string extension
angryPodo Feb 11, 2026
4ed8948
refactor: update ui state on log failure in diary write viewmodel
angryPodo Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/common/src/main/java/com/hilingual/core/common/extension/StringExt.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package com.hilingual.core.common.extension

private val EMOJI_REGEX = Regex("[\\p{So}\\p{Cn}]+")

fun String.removeEmoji(): String = this.replace(EMOJI_REGEX, "")
24 changes: 0 additions & 24 deletions core/common/src/main/java/com/hilingual/core/common/util/EmojiFilter.kt
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...c/main/java/com/hilingual/core/designsystem/component/textfield/HilingualLongTextField.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import androidx.compose.ui.platform.LocalSoftwareKeyboardController
import androidx.compose.ui.text.input.ImeAction
import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import com.hilingual.core.common.util.EmojiFilter.removeEmoji
import com.hilingual.core.common.extension.removeEmoji
import com.hilingual.core.designsystem.theme.HilingualTheme

@Composable
Expand Down
2 changes: 1 addition & 1 deletion ...ion/diarywrite/src/main/java/com/hilingual/presentation/diarywrite/DiaryWriteViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ internal class DiaryWriteViewModel @Inject constructor(
_uiState.update { it.copy(topicKo = topic.topicKor, topicEn = topic.topicEn) }
}
.onLogFailure {
_sideEffect.emit(DiaryWriteSideEffect.ShowErrorDialog)
_uiState.update { it.copy(topicKo = "", topicEn = "") }
}
}
}
Expand Down
Loading