refactor(ai-elements): wrap live message bubble#525
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR size advisoryThis PR adds 1645 lines of substantive change. CONTRIBUTING.md defines a soft limit of ~400 LOC. If the PR is genuinely cohesive (e.g. an architecture map, a generated migration, a deletion of a dead module), no action is needed. Otherwise consider:
This is advisory — it does not block the merge. |
✅ Dogfood Visual QA Gate: PASSED
ArtifactsDownload the Generated by Dogfood QA Gate |
|
Demo: walkthrough of the surfaces this PR changed is available as a workflow artifact ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
convexToUIParts().renderPartsthe canonical ordered dispatcher for FastAgentPanel messages.Why
The previous aggregate rendering path could not safely adopt AI Elements without risking reordered or duplicated domain content. Independent review also caught separator drift across multiple reasoning parts and valid falsy tool results (
false,0, and empty string) disappearing; both now have failing-first regressions.Validation
npx vitest run src/features/agents/components/FastAgentPanel/__tests__/FastAgentUIMessageBubble.contract.test.tsx— 15 passednpx vitest run src/features/agents/components/FastAgentPanel— 147 passed, 19 skippednpx vitest run src/features/agents/components/FastAgentPanel/__tests__/MessageBubble.streaming.test.tsx— 1 passednpx tsc --noEmit --pretty falsenpx vitest run src/design/designSystem.test.ts— 11 passednpm run lint:design— 0 high findingsnpm run buildassets/shiki/service-worker precache entriesRelease
Ready for the repository P0 workflow: required checks first, then CI-gated squash merge. No admin bypass.