fix(agents): project strict query summaries#528
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR size advisoryThis PR adds 1018 lines of substantive change. CONTRIBUTING.md defines a soft limit of ~400 LOC. If the PR is genuinely cohesive (e.g. an architecture map, a generated migration, a deletion of a dead module), no action is needed. Otherwise consider:
This is advisory — it does not block the merge. |
✅ Dogfood Visual QA Gate: PASSED
ArtifactsDownload the Generated by Dogfood QA Gate |
|
Demo: walkthrough of the surfaces this PR changed is available as a workflow artifact ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentPlanningandagentMemorydatabase documents onto their strict public Convex return contracts, stripping_creationTimeand internal initializer fields.Production P0 reproduced
Signed-in production dogfood sent a real tool-search prompt. The panel entered
Thinking..., then the FastAgentPanel error boundary replaced chat becausedomains/agents/agentPlanning:listPlansreturned raw rows with fields rejected by its strict validator. Retry reproduced once, so the run stopped per the bounded QA rule. This patch fixes that contract mismatch and the adjacent memory variants. It does not deploy Convex out of band; the normal main-branch workflow owns deployment after merge.Validation
npx vitest run convex/__tests__/agentPlanning.listPlans.test.ts --reporter=verbose(7/7)npx vitest run src/features/agents/components/FastAgentPanel --reporter=dot(203 passed, 19 skipped)npx vitest run src/design/designSystem.test.ts --reporter=verbose(13/13)npx vitest run src/features/agents/components/FastAgentPanel/__tests__/MessageBubble.streaming.test.tsx --reporter=verbose(1/1)npx tsc -p convex --noEmit --pretty falsenpx tsc --noEmit --pretty falsenpm run lint:design(0 high-severity findings; existing medium/low inventory remains)npm run buildRelease Notes
Typecheck,Runtime smoke,Build,Tier B vs preview URL.convex/**changed, monitor the automaticConvex Deployrun after merge. Do not run a manual production deploy.