Skip to content

fix(agents): project strict query summaries#528

Merged
HomenShum merged 2 commits into
mainfrom
fix/agent-query-summary-contracts
Jul 14, 2026
Merged

fix(agents): project strict query summaries#528
HomenShum merged 2 commits into
mainfrom
fix/agent-query-summary-contracts

Conversation

@HomenShum

Copy link
Copy Markdown
Owner

Summary

  • Project agentPlanning and agentMemory database documents onto their strict public Convex return contracts, stripping _creationTime and internal initializer fields.
  • Remove two unused always-on FastAgentPanel subscriptions whose query failure could unmount the signed-in chat surface.
  • Add registered-handler regression coverage for plan, memory, and episodic reads, including the initializer-shaped row that reproduced the production failure.
  • Reconcile the AI Elements migration/design/changelog governance after PRs feat(ai-elements): batch-1 migration + design/UI-contract governance + Codex handoff #516-refactor(ai-elements): migrate live event cards #527; the adoption program remains honestly 11/26 complete.

Production P0 reproduced

Signed-in production dogfood sent a real tool-search prompt. The panel entered Thinking..., then the FastAgentPanel error boundary replaced chat because domains/agents/agentPlanning:listPlans returned raw rows with fields rejected by its strict validator. Retry reproduced once, so the run stopped per the bounded QA rule. This patch fixes that contract mismatch and the adjacent memory variants. It does not deploy Convex out of band; the normal main-branch workflow owns deployment after merge.

Validation

  • npx vitest run convex/__tests__/agentPlanning.listPlans.test.ts --reporter=verbose (7/7)
  • npx vitest run src/features/agents/components/FastAgentPanel --reporter=dot (203 passed, 19 skipped)
  • npx vitest run src/design/designSystem.test.ts --reporter=verbose (13/13)
  • npx vitest run src/features/agents/components/FastAgentPanel/__tests__/MessageBubble.streaming.test.tsx --reporter=verbose (1/1)
  • npx tsc -p convex --noEmit --pretty false
  • npx tsc --noEmit --pretty false
  • npm run lint:design (0 high-severity findings; existing medium/low inventory remains)
  • npm run build
  • Signed-in production tool-flow rerun after CI-gated merge, automatic Convex deploy, and Vercel production deployment

Release Notes

  • Required checks expected: Typecheck, Runtime smoke, Build, Tier B vs preview URL.
  • Merge policy: auto + squash + delete branch; never admin bypass.
  • Because convex/** changed, monitor the automatic Convex Deploy run after merge. Do not run a manual production deploy.
  • A follow-up evidence-only PR will record the canonical squash SHA, fresh production browser journey, and honest visual proof boundaries.

@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodebench-ai Ready Ready Preview, Comment Jul 14, 2026 1:19pm

Request Review

@HomenShum HomenShum enabled auto-merge (squash) July 14, 2026 13:18
@github-actions

Copy link
Copy Markdown

PR size advisory

This PR adds 1018 lines of substantive change. CONTRIBUTING.md defines a soft limit of ~400 LOC.

If the PR is genuinely cohesive (e.g. an architecture map, a generated migration, a deletion of a dead module), no action is needed. Otherwise consider:

  • splitting into 2-3 PRs along independent concerns
  • pre-discussing the architecture change in a GitHub Discussion before merge

This is advisory — it does not block the merge.

@github-actions

Copy link
Copy Markdown

✅ Dogfood Visual QA Gate: PASSED

Check Status
Screenshots 23 captured (pass)
Walkthrough 9 chapters (pass)
Key Frames 9 extracted (pass)
Scribe Steps 8 how-to steps (pass)
Build success
Artifacts

Download the dogfood-evidence-337fbb3 artifact from the Actions tab for full screenshots, frames, and walkthrough video.


Generated by Dogfood QA Gate

@HomenShum HomenShum merged commit 849ff3e into main Jul 14, 2026
16 of 17 checks passed
@HomenShum HomenShum deleted the fix/agent-query-summary-contracts branch July 14, 2026 13:24
@github-actions

Copy link
Copy Markdown

Demo: walkthrough of the surfaces this PR changed is available as a workflow artifact (pr-demo-528) at https://github.com/HomenShum/NodeBenchAI/actions/runs/29336324472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants