refactor(redesign): legacy sweep — delete proven-dead code from the one-chat era#587
Merged
Conversation
…ne-chat era Every deletion backed by a zero-consumers grep proof from a read-only hunt (Phase-C files excluded — that agent owns them): - ChatSurface: dead branchFromTurn→onBranch chain (prop threaded through StreamingAnswer, rendered nothing since #583), orphaned traceToToolCalls, four dead import groups (isStructuredAnswer, ContextMenu*, Tooltip*, ResearchStage types) left by the 847-line Phase A cut. - src/features/agents/components/ai/ wrapper layer removed entirely (AiMessage/AiConversation/AiPromptInput + barrel + story): zero runtime importers — FastAgentPanel wires primitives directly and completed answers render the canonical ChatAssistantMessage. designSystem registry + test now govern the canonical component's home, with an explicit not.toContain so the dead path cannot silently return. - ReproducibleChatPage: latency/cost formatting deduplicated — banner keeps page identity (tier · model · date); the canonical receipt line is the single telemetry source. Kept deliberately: guard-pinned rd-shell--chat-no-inspector contract marker; backend/frontend sourceUrl twins (by-design pair). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
HomenShum
enabled auto-merge (squash)
July 18, 2026 21:08
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR size advisoryThis PR adds 5125 lines of substantive change. CONTRIBUTING.md defines a soft limit of ~400 LOC. If the PR is genuinely cohesive (e.g. an architecture map, a generated migration, a deletion of a dead module), no action is needed. Otherwise consider:
This is advisory — it does not block the merge. |
✅ Dogfood Visual QA Gate: PASSED
ArtifactsDownload the Generated by Dogfood QA Gate |
|
Demo: walkthrough of the surfaces this PR changed is available as a workflow artifact ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion cleanup to the completed one-chat unification (A #583 · B #584 · C #586). Every deletion backed by a zero-consumers grep proof from a read-only hunt:
branchFromTurn→onBranchchain (prop threaded through StreamingAnswer, rendered nothing since feat(redesign): one chat interface — flagship answer is chat-shaped, unified #583), orphanedtraceToToolCalls, four dead import groups left by the Phase A 847-line cut.src/features/agents/components/ai/wrapper layer removed entirely (AiMessage/AiConversation/AiPromptInput + barrel + story): zero runtime importers — FastAgentPanel wires primitives directly; completed answers render the canonicalChatAssistantMessage. Design-system registry + test updated to govern the canonical component's home, with an explicitnot.toContainso the dead path cannot silently return.Kept deliberately (hunter-flagged, verified): guard-pinned
rd-shell--chat-no-inspectorcontract marker; backend/frontendsourceUrltwins (by-design pair).Verification
tsc0 · build clean · 512 tests green across redesign + agents + design-governance + convex suites (incl. rewritten registry test)🤖 Generated with Claude Code