Add semantic validation for CSS property names and value types #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS parser performs syntactic parsing but lacks semantic validation, silently accepting typos like
colr: redand invalid combinations likecolor: 10px.Changes
Core Validation (
CSSValidator)--*), vendor prefixes (-webkit-,-moz-,-ms-,-o-), and global keywords (inherit,initial,unset,revert,revert-layer)Integration
AbstractCSSParser.handleProperty()to invoke validator when enabledsetSemanticValidationEnabled(boolean)configuration APIData
css-properties.txtresource file with 232 known CSS propertiesValidationWarningclass with INFO/WARNING/ERROR severity levelsUsage
Parsing
.example { colr: red; }now reports:Test Coverage
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
commons.apache.org/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.11 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/htmlunit-cssparser/htmlunit-cssparser org.codehaus.plexus.classworlds.launcher.Launcher clean verify -DskipTests=false(dns block)junit.org/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.11 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/htmlunit-cssparser/htmlunit-cssparser org.codehaus.plexus.classworlds.launcher.Launcher clean verify -DskipTests=false(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Add Semantic Validation to CSS Parser
Problem
The current CSS parser performs syntactic parsing but lacks semantic validation. This means:
colr: redinstead ofcolor: red)color: 10px)width: red)Current behavior:
All of the above parse successfully without any warnings, leading to CSS that won't work as expected.
Solution
Implement a comprehensive semantic validation layer that validates:
Implementation Plan
1. Create CSSValidator Class