Move Bot Data Into JSON - #1
Open
greg-randall wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I pulled all of the bot info code from the main PHP file and moved it into a JSON, so that longer term it's easier to maintain the bot info separate from the PHP file itself.
This mostly involved looking through detect_bot_name(), get_llm_bot_labels(), and get_bot_favicon_domain(), combining the information and creating a JSON 'bot-info.json'. Then rewriting those functions to use the data supplied by get_bot_data(), which checks cache, then validates and caches from file. The WordPress cache of the files is only updated when the plugin version changes.