Skip to content

feat: Support snap to pixel for RectangleLabels #7983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 21, 2025
Merged

feat: Support snap to pixel for RectangleLabels #7983

merged 14 commits into from
Jul 21, 2025

Conversation

niklub
Copy link
Collaborator

@niklub niklub commented Jul 15, 2025

Added ability to snap bounding box annotation to the pixel grid via:

<RectangleLabels name="bbox" toName="image" snap="pixel"/>

https://www.loom.com/share/a362e1747c2543e487be344ca20f4827?sid=05df6648-222e-4f80-8ede-64adc71a195f

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit a04856b
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/687e6ef8ba4906000833df02
😎 Deploy Preview https://deploy-preview-7983--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the feat label Jul 15, 2025
Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit a04856b
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/687e6ef8935f310008334114
😎 Deploy Preview https://deploy-preview-7983--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit bcb17ff
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/687676b32521fe000851eb91
😎 Deploy Preview https://deploy-preview-7983--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit bcb17ff
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/687676b33075820008e91dea
😎 Deploy Preview https://deploy-preview-7983--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit a04856b
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/687e6ef883cf480007d9ac3e
😎 Deploy Preview https://deploy-preview-7983--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit a04856b
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/687e6ef810425f0008ad8926
😎 Deploy Preview https://deploy-preview-7983--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 12 lines in your changes missing coverage. Please review.

Project coverage is 65.88%. Comparing base (b7fc7f7) to head (a04856b).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
web/libs/editor/src/regions/RectRegion.jsx 58.82% 7 Missing ⚠️
web/libs/editor/src/tools/Rect.js 68.75% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7983      +/-   ##
===========================================
+ Coverage    63.68%   65.88%   +2.19%     
===========================================
  Files          715      504     -211     
  Lines        50292    33403   -16889     
  Branches      8589     8595       +6     
===========================================
- Hits         32027    22006   -10021     
+ Misses       18262    11394    -6868     
  Partials         3        3              
Flag Coverage Δ
lsf-e2e 59.49% <60.60%> (?)
lsf-integration 55.61% <60.60%> (+<0.01%) ⬆️
lsf-unit 9.39% <0.00%> (-0.01%) ⬇️
pytests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hlomzik
Copy link
Collaborator

hlomzik commented Jul 16, 2025

We should test regions restoration via:

  • load submitted annotation
  • switch between annotations
  • undo/redo
  • history switching
  • switching between images for MIG

Code looks good! Would be also nice to have screenshots/videos in PR to see it in action.

@niklub niklub enabled auto-merge (squash) July 21, 2025 14:13
@niklub niklub disabled auto-merge July 21, 2025 14:54
@hlomzik
Copy link
Collaborator

hlomzik commented Jul 21, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/editor/tests/integration/e2e/video/timeline_region_loop.cy.ts

@niklub niklub merged commit bfec410 into develop Jul 21, 2025
45 of 48 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-bros-187 branch July 21, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants