Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat, update to KordEx v2 #50

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Conversation

gdude2002
Copy link
Contributor

This PR contains the following changes:

  • Bump version to 0.8 (hopefully I did this right, it's not clear how you expect that to happen)
  • Rewrite the build script using the KordEx Gradle plugin
    • Remove KordEx and KTor dependencies as they're provided by the KordEx plugin
    • Remove repositories as they're provided by the KordEx plugin
    • Remove application plugin, jvm target and jar configuration as they're provided by the KordEx plugin
    • Remove the use of Gradle toolchains as that tends to cause far more problems than it solves
    • Move libs.versions.toml to gradle/ as that's the standard now, and remove version catalogue configuration from settings.gradle.kts
    • Centralise plugin versions in settings.gradle.kts
    • Update documentation generator, which has updated your commands documentation
    • Update Logback
    • Update Gradle Wrapper to 8.10
  • Update to Kotlin 2.0.20-RC2
  • Update to KordEx v2, with data collection set to "Minimal"
  • Remove the "about" command and configure the KordEx bundled "about" command with the same options
  • Remove CIO KTor dependency, allowing KTor to pick it automatically (as Kord uses it)
  • Fix the v1 migration (which didn't create the collection it wanted to access)
  • Add .editorconfig from LilyBot, reformat the project, and tell Detekt not to yell about tabs
  • Add assets/, config/ and data/ to gitignore
  • Update workflows to use Java 21
  • Add a workflow for pull requests, so you know that they build

I think that about covers it!

build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
@NotJansel
Copy link
Member

builds fine and else lgtm, merging this

@NotJansel NotJansel merged commit 19efc2c into HyacinthBots:develop Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants