Cloud Compute - Allows for parameterized token/auth url for apis that don't support OIDC discovery - #310
Merged
Merged
Conversation
rma-bryson
force-pushed
the
feature/cloud-compute-support
branch
from
August 3, 2026 17:36
50cc598 to
bf1ad2e
Compare
adamkorynta
requested changes
Aug 3, 2026
MikeNeilson
reviewed
Aug 4, 2026
MikeNeilson
left a comment
MikeNeilson
left a comment
Collaborator
There was a problem hiding this comment.
Looks reasonable overall.
The naming is an issue. May or may not be worth fixing at this point.
That said, we probably want to get the who system setup to be something more... generic overall. Lot of assumption in several places, that really seem like the wrong place (in general, not the PR.)
adamkorynta
reviewed
Aug 4, 2026
… don't support OIDC discovery
…ation in favor of ensuring single request to retrieve well known endpoint to parse auth and token endpoint from.
rma-bryson
force-pushed
the
feature/cloud-compute-support
branch
from
August 13, 2026 17:01
431798a to
cbb07b3
Compare
MikeNeilson
approved these changes
Aug 13, 2026
adamkorynta
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.