Added v4 UIDs #1989
Open
Added v4 UIDs #1989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmsdelmundo
force-pushed
the
gdm-UID2-5837-v4-uid
branch
from
cc3ddd3 to
6613350
Compare
gmsdelmundo
force-pushed
the
gdm-UID2-5837-v4-uid
branch
from
2d8cf28 to
c702d41
Compare
writing key id as 3 bytes big endian format
…rator into gdm-UID2-5837-v4-uid
sophia-chen-ttd
approved these changes
Sep 30, 2025
gmsdelmundo
force-pushed
the
gdm-UID2-5837-v4-uid
branch
from
796e211 to
baecb11
Compare
| advertisingId = TokenUtils.getAdvertisingIdV4(firstLevelHashIdentity.identityScope, firstLevelHashIdentity.identityType, env, firstLevelHashIdentity.id, key); | ||
| incrementAdvertisingIdVersionCounter("v4"); | ||
| } catch (Exception e) { | ||
| LOGGER.error("Exception when generating V4 advertising ID", e); |
There was a problem hiding this comment.
This should throw and result in a 500? Will something else up the stack throw if advertisingId is null?
There was a problem hiding this comment.
Updated it to throw a RuntimeException instead, similarly to v2/v3, which eventually results in a 500 HTTP error response
|
|
||
| private byte[] getPreviousAdvertisingId(UserIdentity firstLevelHashIdentity, SaltEntry rotatingSalt, Instant asOf) { | ||
| private void incrementAdvertisingIdVersionCounter(String version) { | ||
| Counter.builder("uid2_raw_uid_version_total") |
There was a problem hiding this comment.
Can you prebuild the counters and map version ints to them? Registering has overhead and this builder causes unnecessary allocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4 UID generation
v4TokenUtils.javav4TokenUtilsTest.javav2/v3 vs v4 UID logic
TokenUtils.javaUIDOperatorService.javaUIDOperatorVerticleTest.javaIdentity enum parity
IdentityEnvironment.javaIdentityScope.javaIdentityType.javaIdentityVersion.javaTokenUtils.javaOther formatting changes