add link id regex field to services #475
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cYKatherine
reviewed
Jun 17, 2025
| @@ -57,6 +72,7 @@ public String toString() { | |||
| ", siteId=" + siteId + | |||
| ", name='" + name + '\'' + | |||
| ", roles=" + roles + | |||
| ", linkIdRegex=" + linkIdRegex + | |||
There was a problem hiding this comment.
Would it fail when linkIdRegex is null?
There was a problem hiding this comment.
no, java handles the concatenation by automatically converting null to "null"
| return serviceId == service.serviceId && siteId == service.siteId && name.equals(service.name) && roles.equals(service.roles); | ||
| boolean compare = serviceId == service.serviceId && siteId == service.siteId && name.equals(service.name) && roles.equals(service.roles); | ||
| if (linkIdRegex == null || service.linkIdRegex == null) { | ||
| return compare && linkIdRegex == service.linkIdRegex; |
There was a problem hiding this comment.
We can use && Objects.equals(linkIdRegex, service.linkIdRegex) to skip the null tests.
| @@ -30,6 +37,14 @@ public int getSiteId() { | |||
| return siteId; | |||
| } | |||
|
|
|||
| public String getLinkIdRegex() { | |||
There was a problem hiding this comment.
nit: Can we move the new methods so that getSiteId and setSiteId are next to each other?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.