Conversation
This commit ensures that when the cached copy of a dataset expires due to failure to download the dataset over the specified period of time that the cached URL and ETag fields are blanked out. Resolves #137
This commit adds two tests which checks that the creation of a dataset record sets the most_recent_*_attempt_error_occurred flags to false, and that after a successful check for a dataset the most_recent_head_attempt_error_occurred flag is false (the get flag was already checked).
This DB migration both sets a default of false for the error flags and sets all existing null values to false (if there are any existing values with null, it is because the relevant check hasn't been done over given the time frame, so no error has occurred).
This commit changes the dataset creation code so that a new dataset object has its error occurred flags set to false. Resolves #136.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: