Upgrade Node for main app and npm in CI

.github/workflows/develop-func-ci.yml

@@ -2,7 +2,8 @@ name: CI_AutoMerge_Dependabot
 
 on:
   pull_request:
-    paths-ignore: # https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
+    paths-ignore:
+      # https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
       - "**/README.md"
       - "**/dependabot.yml"
       - ".github/workflows/prod-func-ci.yml"
@@ -27,7 +28,7 @@ jobs:
   build:
     uses: IATI/.github/.github/workflows/build_node_save.yaml@main
     with:
-      npm_version: ^10
+      npm_version: ^11
       save_artifact: false
 
   automerge:
@@ -37,6 +38,6 @@ jobs:
       pull-requests: write
       contents: write
     steps:
-      - uses: fastify/github-action-merge-dependabot@v3.11
+      - uses: fastify/github-action-merge-dependabot@v3.12
         with:
           github-token: ${{secrets.GITHUB_TOKEN}}

.github/workflows/develop-func-deploy.yml

@@ -3,7 +3,8 @@ name: Deploy_To_Dev_Function_On_Push
 on:
   workflow_dispatch: # Allow Manual Run from GitHub
   push:
-    paths-ignore: # https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
+    paths-ignore:
+      # https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
       - "**/README.md" # don't run on README.md file updates anywhere in repo
       - "**/dependabot.yml"
       - ".github/workflows/prod-func-ci.yml"
@@ -47,7 +48,7 @@ jobs:
     if: ${{ needs.should_run.outputs.should_run == 'true' }}
     uses: IATI/.github/.github/workflows/build_node_save.yaml@main
     with:
-      npm_version: ^10
+      npm_version: ^11
       save_artifact: true
       artifact_name: build-artifact-dev
 
@@ -56,7 +57,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download build artifact
-        uses: actions/download-artifact@v7
+        uses: actions/download-artifact@v8
         with:
           name: build-artifact-dev
 
@@ -66,7 +67,7 @@ jobs:
           rm build-artifact-dev.zip
 
       - name: "Login via Azure CLI"
-        uses: azure/login@v2.3.0
+        uses: azure/login@v3.0.0
         with:
           creds: ${{ env.AZURE_CREDENTIALS }} # Service Principal credentials saved in GitHub Secrets
 
@@ -126,7 +127,7 @@ jobs:
                   "value": "${{ env.VALIDATOR_FUNC_KEY }}",
                   "slotSetting": false
                 },
-                { 
+                {
                     "name": "AzureWebJobsSecretStorageType",
                     "value": "keyvault",
                     "slotSetting": false
@@ -164,7 +165,7 @@ jobs:
             ]
 
       - name: "Run Azure Functions Action"
-        uses: Azure/[email protected].3
+        uses: Azure/[email protected].6
         with:
           app-name: func-${{ env.NAME }}-${{ env.STAGE }}
 

.github/workflows/prod-func-deploy.yml

@@ -34,7 +34,7 @@ jobs:
   build_save:
     uses: IATI/.github/.github/workflows/build_node_save.yaml@main
     with:
-      npm_version: ^10
+      npm_version: ^11
       save_artifact: true
       artifact_name: build-artifact-prod
 
@@ -43,7 +43,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Download build artifact
-        uses: actions/download-artifact@v7
+        uses: actions/download-artifact@v8
         with:
           name: build-artifact-prod
 
@@ -53,7 +53,7 @@ jobs:
           rm build-artifact-prod.zip
 
       - name: "Login via Azure CLI"
-        uses: azure/login@v2.3.0
+        uses: azure/login@v3.0.0
         with:
           creds: ${{ env.AZURE_CREDENTIALS }} # Service Principal credentials saved in GitHub Secrets
 
@@ -151,7 +151,7 @@ jobs:
             ]
 
       - name: "Run Azure Functions Action"
-        uses: Azure/[email protected].3
+        uses: Azure/[email protected].6
         with:
           app-name: func-${{ env.NAME }}-${{ env.STAGE }}
 

.nvmrc

@@ -1 +1 @@
-lts/iron
+lts/krypton

README.md

@@ -20,12 +20,10 @@ See OpenAPI specification `postman/schemas/index.yaml`. To view locally in Swagg
 #### blob-trigger-adhoc-file
 
 - Blob Trigger
-
   - When file is added to blob storage container with name `ADHOC_CONTAINER`, this Function is triggered.
   - `/api/pvt/adhoc/upload` or `/api/pvt/adhoc/url` are the endpoints used to add files to blob storage.
 
 - Actions
-
   - Sends file to Validator API
   - Saves validation report and metadata to `adhoc_validation` table
 
@@ -155,7 +153,7 @@ It would be better to spin up a dedicate test environment on Github using docker
 
 #### Against a local instance of `validator-services`
 
-If you want to test against a local instance of `validator-services` you need to have it pointed to a Unified Pipeline database and an Azure storage account.
+If you want to run the tests against a local instance of `validator-services` you need to have your locally running version of `validator-services` pointed to a Unified Pipeline database and an Azure storage account. You can do this using the [Unified Data Platform Local Dev](https://github.com/IATI/unified-data-platform-local-dev) setup.
 
 If you use a local database, you will need to ensure that you have run the Pipeline refresher with a reasonable number of datasets through to the validate stage, because the tests search for a dataset which has warnings, to check various things.
 
@@ -180,7 +178,6 @@ To run against production, use `integration-tests/envs/validator-services-direct
 ### Modifying/Adding Tets
 
 1. Check the tests in Postman are in sync with the Github repo:
-
    - Export the `validator-services` collection from the Postman client to `./integration-tests`
    - Run `npm run format`
    - Run `git diff integration-tests/validator-services-tests.postman_collection.json`

blob-trigger-adhoc-file/index.js

@@ -9,9 +9,9 @@ import {
 
 export default async function blobTriggerAdhocFile(context) {
   let errorStatus = null;
-  let result = null;
+  let result;
   let valid = null;
-  let report = null;
+  let report;
 
   try {
     if (isInMaintenanceMode(maintenanceModes.NO_WRITE)) {

host.json

@@ -10,6 +10,6 @@
   },
   "extensionBundle": {
     "id": "Microsoft.Azure.Functions.ExtensionBundle",
-    "version": "[2.*, 3.0.0)"
+    "version": "[4.0.0, 5.0.0)"
   }
 }