Change OrderedDict to dict in ansible driver progress events#289
Open
suman-savanur3 wants to merge 1 commit intoIBM:developfrom
Open
Change OrderedDict to dict in ansible driver progress events#289suman-savanur3 wants to merge 1 commit intoIBM:developfrom
suman-savanur3 wants to merge 1 commit intoIBM:developfrom
Conversation
lokanalla
approved these changes
Jun 7, 2024
Contributor
lokanalla
left a comment
lokanalla
left a comment
There was a problem hiding this comment.
You may need to raise a separate PR for ignition version update once ignition is released!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #282
OrderedDict is not compatible with latest ansible, hence changing the OrderedDict to dict that maintain insertion order after python version 3.7.