perf: use normal feed for one-off changes #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiri
reviewed
Apr 7, 2025
| } | ||
| if (invalidOptions.size() > 0) { | ||
| throwInvalidOptionsMessageWith(String.format(" when using %s.", ChangesFollower.class.getSimpleName()), invalidOptions); | ||
| throwInvalidOptionsMessageWith(invalidOptions); |
Contributor
There was a problem hiding this comment.
No against it, but what's a rational behind this change?
Member
Author
There was a problem hiding this comment.
It was obsolete, I think the message was originally formatted here, but later it was adjusted and the suffix param of throwInvalidOptionsMessageWith was no longer used, but it wasn't removed. This just cleans up that oversight.
mojito317
approved these changes
Apr 16, 2025
ricellis
force-pushed
the
i445-follower-one-off
branch
from
4c75eee to
60be197
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Use
normalfeed mode for changes follower one-offFINITEmode.Fixes: s1116 / i445
Note: An existing issue is required before opening a PR.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Angular Commit Message Guidelines.
PR Type
What is the current behavior?
Currently the changes follower uses
longpollfeed type is for bothstart(LISTEN) andstartOneOff(FINITE) cases.If the number of changes is an exact multiple of the follower batch size this causes the one-off collection to unnecessarily wait for the longpoll period (57 s) when it reaches the end of the available changes. This is a rare occurrence, but one more common edge case is empty databases (i.e. the zero multiple).
What is the new behavior?
Switch to use the
normalfeed type forstartOneOff(FINITE) mode thereby optimizing thestartOneOffcases to avoid waiting unnecessarily.Does this PR introduce a breaking change?
Other information