Skip to content

migrate all openshift legacy commands to catalog - #1255

Merged
Shubhamag12 merged 6 commits into
IBM:mainfrom
Shubhamag12:migrate-cmds
Aug 17, 2026
Merged

migrate all openshift legacy commands to catalog#1255
Shubhamag12 merged 6 commits into
IBM:mainfrom
Shubhamag12:migrate-cmds

Conversation

@Shubhamag12

@Shubhamag12 Shubhamag12 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

This PR migrates all openshift cmd to use catalog apis same as podman.

  1. Legacy code is hidden behind --legacy flag.
  2. Info is split into podman and openshift runtime and based on legacy flag here: migrate info cmd to use catalog api #1256
  3. Rest of commands have common functionality, so the split is not required in that case

@adarshagrawal38

Copy link
Copy Markdown
Member

Hey @Shubhamag12 shall we allow shorthand notation for runtime flag input
Please update the line

Suggestion:

ApplicationCmd.PersistentFlags().StringVar(&runtimeType, "runtime", "r", "", fmt.Sprintf("runtime to use (options: %s, %s) (required)", types.RuntimeTypePodman, types.RuntimeTypeOpenShift))

@Shubhamag12

Copy link
Copy Markdown
Contributor Author

Hey @Shubhamag12 shall we allow shorthand notation for runtime flag input Please update the line

Suggestion:

ApplicationCmd.PersistentFlags().StringVar(&runtimeType, "runtime", "r", "", fmt.Sprintf("runtime to use (options: %s, %s) (required)", types.RuntimeTypePodman, types.RuntimeTypeOpenShift))

we can do that, that will require doc changes as well.
Thoughts? @yussufsh @mayuka-c

@yussufsh

Copy link
Copy Markdown
Member

Hey @Shubhamag12 shall we allow shorthand notation for runtime flag input Please update the line
Suggestion:

ApplicationCmd.PersistentFlags().StringVar(&runtimeType, "runtime", "r", "", fmt.Sprintf("runtime to use (options: %s, %s) (required)", types.RuntimeTypePodman, types.RuntimeTypeOpenShift))

we can do that, that will require doc changes as well. Thoughts? @yussufsh @mayuka-c

We can do that, yes. No need to change docs during deployment or something; let it be explicit in the docs. Help messages are picked up anyway to depict the shorthand.

yussufsh
yussufsh previously approved these changes Aug 17, 2026

@yussufsh yussufsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

yussufsh
yussufsh previously approved these changes Aug 17, 2026
Signed-off-by: sagarwal-ibm <sagarwal@ibm.com>
Signed-off-by: sagarwal-ibm <sagarwal@ibm.com>
Signed-off-by: sagarwal-ibm <sagarwal@ibm.com>
Signed-off-by: sagarwal-ibm <sagarwal@ibm.com>
Signed-off-by: sagarwal-ibm <sagarwal@ibm.com>
Signed-off-by: sagarwal-ibm <sagarwal@ibm.com>
@Shubhamag12
Shubhamag12 merged commit 31b30f5 into IBM:main Aug 17, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants