fix: read IBM_CREDENTIALS_FILE from env var so Java integration tests actually run - #16
Merged
Merged
Conversation
IdanAdar
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SdkIntegrationTestBase.skipTests()was callingSystem.getProperty("IBM_CREDENTIALS_FILE"),which reads JVM system properties set via
-DKEY=valueflags — not shell environment variables.The pipeline sets
IBM_CREDENTIALS_FILEviaexport, soSystem.getProperty()alwaysreturned
null,skipTests()threw aSkipException, and all three IT methods were silentlyskipped on every pipeline run. The Maven
verifyoutput showed 29 tests in ~3.6s — those wereall unit tests; no real API call was ever made.
Fix:
System.getProperty()→System.getenv().After this, the pipeline will run
testCreateVaultAdmintoken → testGetInstance → testDeleteInstanceAdmintokensagainst the real instance.