Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/model factory default #12

Closed
wants to merge 4 commits into from
Closed

Fix/model factory default #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd2cbba
simplify config files for vit sen1floods11
CarlosGomes98 May 24, 2024
11010f8
Merge branch 'main' into feature/simplify_vit
CarlosGomes98 May 24, 2024
8730ade
remove unnecessary parameters from config file
CarlosGomes98 May 24, 2024
580107b
fix bad default for in_channels
CarlosGomes98 May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion examples/confs/sen1floods11_vit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ model:
decoder: FCNDecoder
pretrained: true
backbone: prithvi_vit_100
backbone_pretrain_img_size: 512
decoder_channels: 256
in_channels: 6
bands:
Expand Down
10 changes: 0 additions & 10 deletions examples/confs/sen1floods11_vit_local_ckpt.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,16 +77,6 @@ model:
decoder: FCNDecoder
pretrained: true
backbone: prithvi_vit_100
backbone_pretrain_img_size: 512
backbone_embed_dim: 768
backbone_num_heads: 12
backbone_decoder_depth: 8
backbone_decoder_num_heads: 16
backbone_decoder_embed_dim: 512
backbone_mlp_ratio: 4
backbone_patch_size: 16
backbone_in_chans: 6
backbone_num_frames: 1
backbone_pretrained_cfg_overlay:
file: examples/Prithvi_100M.pt
decoder_channels: 256
Expand Down
2 changes: 1 addition & 1 deletion src/terratorch/models/prithvi_model_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def build_model(
backbone: str | nn.Module,
decoder: str | nn.Module,
bands: list[HLSBands | int],
in_channels: int = int | None, # this should be removed, can be derived from bands. But it is a breaking change
in_channels: int | None = None, # this should be removed, can be derived from bands. But it is a breaking change
num_classes: int | None = None,
pretrained: bool = True, # noqa: FBT001, FBT002
num_frames: int = 1,
Expand Down
Loading