Remove IBM GenAI support and moved legacy GenAI metrics to use CrossProviderInferenceEngine #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
Added cross provide inference engine to harm_rating. Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
yoavkatz
commented
Jan 15, 2025
| @@ -27,6 +25,6 @@ | |||
|
|
|||
| add_to_catalog( | |||
| metric, | |||
| f"metrics.llm_as_judge.rating.{model_label}_template_{template_label}", | |||
| f"metrics.llm_as_judge.rating.{model_label}.{template_label}", | |||
There was a problem hiding this comment.
@elronbandel @ShirApp - Please see the change in metric name I made to make table2text rating be consistent with other rating engine. As far as I saw the only use was in scigen.py.
There was a problem hiding this comment.
It looks fine. Yes, we used it only for scigen.
yoavkatz
changed the title
Signed-off-by: Yoav Katz <[email protected]>
Signed-off-by: Yoav Katz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.