Skip to content

Conversation

@zhouyuan
Copy link
Collaborator

fix decimal avg function precision issue

@unidevel
Copy link

unidevel commented Jul 2, 2025

alchemy merge

@prestodb-ci
Copy link
Collaborator

alchemy link a464bf5

@prestodb-ci
Copy link
Collaborator

Added new rebase item:

prestodb-ci pushed a commit that referenced this pull request Jul 2, 2025
fix decimal avg function precision issue

Alchemy-item: [[6020 ] Spark sql avg agg function support decimal](#30 (comment)) commit 1/1 - a464bf5
prestodb-ci pushed a commit that referenced this pull request Jul 2, 2025
fix decimal avg function precision issue

Alchemy-item: [[6020 ] Spark sql avg agg function support decimal](#30 (comment)) commit 1/1 - a464bf5
prestodb-ci pushed a commit that referenced this pull request Jul 3, 2025
fix decimal avg function precision issue

Alchemy-item: [[6020 ] Spark sql avg agg function support decimal](#30 (comment)) commit 1/1 - a464bf5
prestodb-ci pushed a commit that referenced this pull request Jul 3, 2025
fix decimal avg function precision issue

Alchemy-item: [[6020 ] Spark sql avg agg function support decimal](#30 (comment)) commit 1/1 - a464bf5
prestodb-ci pushed a commit that referenced this pull request Jul 3, 2025
fix decimal avg function precision issue

Alchemy-item: [[6020 ] Spark sql avg agg function support decimal](#30 (comment)) commit 1/1 - a464bf5
prestodb-ci pushed a commit that referenced this pull request Jul 3, 2025
fix decimal avg function precision issue

Alchemy-item: [[6020 ] Spark sql avg agg function support decimal](#30 (comment)) commit 1/1 - a464bf5
prestodb-ci pushed a commit that referenced this pull request Jul 3, 2025
fix decimal avg function precision issue

Alchemy-item: [[6020 ] Spark sql avg agg function support decimal](#30 (comment)) commit 1/1 - a464bf5
prestodb-ci pushed a commit that referenced this pull request Jul 3, 2025
fix decimal avg function precision issue

Alchemy-item: [[6020 ] Spark sql avg agg function support decimal](#30 (comment)) commit 1/1 - a464bf5
prestodb-ci pushed a commit that referenced this pull request Jul 4, 2025
fix decimal avg function precision issue

Alchemy-item: [[6020 ] Spark sql avg agg function support decimal](#30 (comment)) commit 1/1 - a464bf5
prestodb-ci pushed a commit that referenced this pull request Jul 6, 2025
fix decimal avg function precision issue

Alchemy-item: [[6020 ] Spark sql avg agg function support decimal](#30 (comment)) commit 1/1 - a464bf5
prestodb-ci pushed a commit that referenced this pull request Jul 7, 2025
fix decimal avg function precision issue

Alchemy-item: [[6020 ] Spark sql avg agg function support decimal](#30 (comment)) commit 1/1 - a464bf5
prestodb-ci pushed a commit that referenced this pull request Jul 7, 2025
fix decimal avg function precision issue

Alchemy-item: [[6020 ] Spark sql avg agg function support decimal](#30 (comment)) commit 1/1 - a464bf5
prestodb-ci pushed a commit that referenced this pull request Jul 7, 2025
fix decimal avg function precision issue

Alchemy-item: [[6020 ] Spark sql avg agg function support decimal](#30 (comment)) commit 1/1 - a464bf5
This was referenced Nov 19, 2025
@prestodb-ci
Copy link
Collaborator

Failed to cherry-pick commit 931992e in rebase request #1392:

exit status 1
error: could not apply 931992ed1... [OAP][15244] Spark sql avg agg function support decimal

Auto-merging velox/functions/sparksql/aggregates/AverageAggregate.cpp
CONFLICT (content): Merge conflict in velox/functions/sparksql/aggregates/AverageAggregate.cpp
Auto-merging velox/functions/sparksql/aggregates/tests/AverageAggregationTest.cpp
CONFLICT (content): Merge conflict in velox/functions/sparksql/aggregates/tests/AverageAggregationTest.cpp

Please:

  1. Rebase your branch with staging/staging-ffa685dd4-rebase and fix the conflict. If the rebase item is a PR, you can change the base branch to this staging branch.
  2. Comment on this issue:
alchemy link [updated comma-separated commit SHAs for this issue] @2025-11-22T03:18:23Z
  1. Re-open Rebase branch staging-ffa685dd4-rebase with staging-ffa685dd4-head (ffa685d) #1392 to retry the cherry-pick.

@liujiayi771
Copy link

@zhouyuan upstream velox already support Spark decimal avg.

@zhouyuan zhouyuan closed this Nov 22, 2025
@prestodb-ci
Copy link
Collaborator

Expired 1 rebase items linked in this issue at 2025-11-22T06:16:20Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants