Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESSOptimizer: Check inputs and check stopping criteria more frequently #1176

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 16, 2023

  • Ensure we have some stopping criterion to not run infinitely long
  • Avoid exceeding stopping criteria by checking them more frequently

* Ensure we have some stopping criterion to not run infinitely long
* Avoid exceeding stopping criteria by checking them more frequently
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f944d3c) 82.93% compared to head (b178187) 82.90%.

Files Patch % Lines
pypesto/optimize/ess/ess.py 69.23% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1176      +/-   ##
===========================================
- Coverage    82.93%   82.90%   -0.04%     
===========================================
  Files          148      148              
  Lines        11693    11704      +11     
===========================================
+ Hits          9698     9703       +5     
- Misses        1995     2001       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pypesto/optimize/ess/ess.py Show resolved Hide resolved
@dweindl dweindl merged commit 4507747 into ICB-DCM:develop Nov 17, 2023
17 checks passed
@dweindl dweindl deleted the ess_check_stopping_criteria branch November 17, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants