fix waterfall start indices #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1200 +/- ##
===========================================
- Coverage 81.52% 81.40% -0.13%
===========================================
Files 148 148
Lines 11753 11753
===========================================
- Hits 9582 9567 -15
- Misses 2171 2186 +15 ☔ View full report in Codecov by Sentry. |
m-philipps
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, when there is more than one optimization result, one might get different
start_indicesdepending on result order. E.g., if a result with fewer multistarts precedes one with more multistarts, the resulting start indices will be limited to the indices of the first result. If the order of the results is opposite, the result with fewer multistarts won't limit the number of starts that will be plotted for the other result.