More flexible OptimizationResultHDF5Writer
#1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1528 +/- ##
===========================================
- Coverage 82.82% 82.75% -0.07%
===========================================
Files 163 163
Lines 14004 14018 +14
===========================================
+ Hits 11599 11601 +2
- Misses 2405 2417 +12 ☔ View full report in Codecov by Sentry. |
auto-merge was automatically disabled
November 27, 2024 13:28
Pull request was converted to draft
Changes: * `OptimizeResult`, `OptimizerResult`(s) can be written by `OptimizationResultHDF5Writer.write()` (Closes ICB-DCM#1526) * `OptimizerResult`s can be written incrementally by `OptimizationResultHDF5Writer.write_optimizer_result()` (Closes ICB-DCM#1527) * Fixed an `AttributeError` in `pypesto.store.save_to_hdf5.check_overwrite` with `h5py.Group`s
dweindl
changed the title
OptimizationResultHDF5Writer.write(OptimizeResult)OptimizationResultHDF5Writer
PaulJonasJost
approved these changes
Nov 28, 2024
If there is demand. I wouldn't do it just for the sake of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only writing
Resultwas supported.Changes:
OptimizeResult,OptimizerResult(s) can be written byOptimizationResultHDF5Writer.write()(ClosesOptimizationResultHDF5Writershould acceptOptimizeResult#1526)OptimizerResults can be written incrementally byOptimizationResultHDF5Writer.write_optimizer_result()(ClosesOptimizationResultHDF5Writershould allow writing individualOptimzerResults#1527)AttributeErrorinpypesto.store.save_to_hdf5.check_overwritewithh5py.Groups