Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select: update for the mkstd version #1541

Merged
merged 11 commits into from
Jan 4, 2025
Merged

Conversation

dilpath
Copy link
Member

@dilpath dilpath commented Dec 17, 2024

  • Deprecated plotting code, which is now provided by the petab_select library.

  • Updated the notebook

  • Updated all code to be compatible with the next petab-select version

  • Wait for the next petab_select release before merging

    • update setup.cfg petab-select version

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.38%. Comparing base (b99ae5b) to head (3eed1e2).
Report is 12 commits behind head on select_class_models.

Files with missing lines Patch % Lines
pypesto/visualize/select.py 37.50% 5 Missing ⚠️
pypesto/select/postprocessors.py 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           select_class_models    #1541      +/-   ##
=======================================================
+ Coverage                79.66%   82.38%   +2.72%     
=======================================================
  Files                      163      163              
  Lines                    14030    13984      -46     
=======================================================
+ Hits                     11177    11521     +344     
+ Misses                    2853     2463     -390     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dilpath dilpath marked this pull request as ready for review January 4, 2025 17:01
@dilpath dilpath merged commit fc140fd into select_class_models Jan 4, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants