Remove OIDC, use OAuth + PKCE with attributes endpoint#5
Open
antspriggs wants to merge 2 commits intomasterfrom
Open
Remove OIDC, use OAuth + PKCE with attributes endpoint#5antspriggs wants to merge 2 commits intomasterfrom
antspriggs wants to merge 2 commits intomasterfrom
Conversation
…point Drop all OIDC/OpenID Connect code paths and simplify the SDK to only use OAuth 2.0 Authorization Code with PKCE. The attributes endpoint (/api/public/v3/attributes.json) is now the sole user data source. Deleted: - IDmeAuthMode enum (oauth/oauthPKCE/oidc) - OIDC models: OIDCDiscovery, UserInfo - JWT validation: JWTValidator, JWKSClient, RSAKeyConverter, JWKS, NonceGenerator - Associated test files Simplified: - IDmeAuth: removed jwksFetcher, userInfo(), ID token validation, auth mode branching - IDmeConfiguration: removed authMode parameter - Credentials/TokenResponse: removed idToken field - AuthorizationRequest/GroupsRequest: always use PKCE, no nonce - IDmeScope: removed openid/profile/email scopes - IDmeEnvironment: removed discoveryURL/jwksURL - IDmeAuthError: removed OIDC-specific error cases - Demo app: removed auth mode picker, OIDC display branches - README: rewritten as 6-step integration guide with demo app references Co-Authored-By: Claude Opus 4.6 <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
gitStream SummaryEstimated Review Time: 10 min |
Co-Authored-By: Claude Opus 4.6 <[email protected]>
ALeoLeonard
approved these changes
Mar 6, 2026
seftena
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/public/v3/attributes.jsonendpoint as the sole user data source (drop/api/public/v3/userinfo)Test plan
swift buildsucceedsswift testpasses (59 tests)🤖 Generated with Claude Code