Skip to content

Fixed root mean squared error computation #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alvaroborras wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed root mean squared error computation #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openfe/FeatureSelector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from .FeatureGenerator import *
from concurrent.futures import ProcessPoolExecutor
from sklearn.feature_selection import mutual_info_regression, mutual_info_classif
from sklearn.metrics import mean_squared_error, log_loss, roc_auc_score
from sklearn.metrics import root_mean_squared_error, log_loss, roc_auc_score
import scipy.special
from datetime import datetime
import warnings
Expand Down Expand Up @@ -562,7 +562,7 @@ def get_init_metric(self, pred, label):
init_metric = log_loss(label, scipy.special.softmax(pred, axis=1),
labels=list(range(pred.shape[1])))
elif self.metric == 'rmse':
init_metric = mean_squared_error(label, pred, squared=False)
init_metric = root_mean_squared_error(label, pred)
elif self.metric == 'auc':
init_metric = roc_auc_score(label, scipy.special.expit(pred))
else:
Expand Down
4 changes: 2 additions & 2 deletions openfe/openfe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from .utils import tree_to_formula, check_xor, formula_to_tree
from sklearn.inspection import permutation_importance
from sklearn.feature_selection import mutual_info_regression, mutual_info_classif
from sklearn.metrics import mean_squared_error, log_loss, roc_auc_score
from sklearn.metrics import root_mean_squared_error, log_loss, roc_auc_score
import scipy.special
from copy import deepcopy
from tqdm import tqdm
Expand Down Expand Up @@ -569,7 +569,7 @@ def get_init_metric(self, pred, label):
init_metric = log_loss(label, scipy.special.softmax(pred, axis=1),
labels=list(range(pred.shape[1])))
elif self.metric == 'rmse':
init_metric = mean_squared_error(label, pred, squared=False)
init_metric = root_mean_squared_error(label, pred)
elif self.metric == 'auc':
init_metric = roc_auc_score(label, scipy.special.expit(pred))
else:
Expand Down