fixing instances of string appending with + #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ErwinJunge Can you help me review this PR? |
ErwinJunge
suggested changes
Oct 25, 2017
Contributor
ErwinJunge
left a comment
ErwinJunge
left a comment
There was a problem hiding this comment.
You seem to be missing a lot of the cases where strings are concatenated by +. The goal is to fix all of the cases.
| if not os.path.exists(full_path): | ||
| break | ||
| return name + '.' + str(i) + extension | ||
| return "{0}.{1}{2}".format(name, str(i), extension) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| ) | ||
| if invalid_folder_name: | ||
| messages.append("Invalid folder name : " + name) | ||
| messages.append('{0}{1}'.format("Invalid folder name : ", name)) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
|
@discentem I think you're probably better off picking something else to work on. PR #48 is pretty close to completion and is doing the same thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per #35