Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better formulation to wrap-up #784

Merged
merged 2 commits into from
Mar 17, 2025
Merged

better formulation to wrap-up #784

merged 2 commits into from
Mar 17, 2025

Conversation

psteinb
Copy link
Contributor

@psteinb psteinb commented Nov 26, 2024

The last sentence of the cross_validation_time.ipynb notebook felt a bit convoluted. I tried my best to improve the formulation.

Copy link
Collaborator

@ArturoAmorQ ArturoAmorQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @psteinb! Here are a couple of comments. Also, the linter fail in the CI is because it's configured to 80 characters max.

Being said that, reworking this whole notebook has been in my list of to do's for a long time. In particular, we want to use a more realistic dataset, give interpretation to resulting R2 and MSE scores, and mention the actual good practices for modeling, e.g. aligning the test size of TimeSeriesSplit with the forecasting task. In case you want to contribute, feel free to submit a more in depth PR.

@@ -220,5 +220,5 @@
# %% [markdown]
# In conclusion, it is really important to not use an out of the shelves
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think "out of the shelves" is grammatically correct nor a common term for the students to know. Maybe we can rephrase the whole paragraph.

@ArturoAmorQ
Copy link
Collaborator

Hi @psteinb are you still working on this PR? Would you mind adding a small mention in the conclusions in the line of:

However, this does not mean that scikit-learn is useless for time-series tasks. In fact, scikit-learn offers useful utilities for time-series analysis (interested readers can see for instance the Time-related feature engineering example in the documentation), and its models can yield even better results when combined with other specialized libraries.

@ArturoAmorQ ArturoAmorQ merged commit 2dbb76d into INRIA:main Mar 17, 2025
3 checks passed
@ArturoAmorQ
Copy link
Collaborator

Thanks for your contribution @psteinb!
My comment here can wait for a further PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants