-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better formulation to wrap-up #784
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @psteinb! Here are a couple of comments. Also, the linter fail in the CI is because it's configured to 80 characters max.
Being said that, reworking this whole notebook has been in my list of to do's for a long time. In particular, we want to use a more realistic dataset, give interpretation to resulting R2 and MSE scores, and mention the actual good practices for modeling, e.g. aligning the test size of TimeSeriesSplit
with the forecasting task. In case you want to contribute, feel free to submit a more in depth PR.
@@ -220,5 +220,5 @@ | |||
# %% [markdown] | |||
# In conclusion, it is really important to not use an out of the shelves |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think "out of the shelves" is grammatically correct nor a common term for the students to know. Maybe we can rephrase the whole paragraph.
Hi @psteinb are you still working on this PR? Would you mind adding a small mention in the conclusions in the line of:
|
Thanks for your contribution @psteinb! |
The last sentence of the
cross_validation_time.ipynb
notebook felt a bit convoluted. I tried my best to improve the formulation.