-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10476 display on create field option #11224
Open
Saixel
wants to merge
10
commits into
develop
Choose a base branch
from
10476-display-on-create-field-option
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+225
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added updateDisplayOnCreate method to DataversePage - Added displayOnCreate handling in DataverseServiceBean - Added displayOnCreate checkbox to dataverse.xhtml - Added displayOnCreate field to DataverseFieldTypeInputLevel
- Remove javadoc comment from updateDisplayOnCreate method in DataversePage.java - Remove inline comment from displayOnCreate setter in DataverseServiceBean.java
- Remove selector changes from dataverse.xhtml as they will be implemented in a separate task focusing on UI improvements
This comment has been minimized.
This comment has been minimized.
stevenwinship
requested changes
Feb 11, 2025
src/main/java/edu/harvard/iq/dataverse/DataverseFieldTypeInputLevel.java
Outdated
Show resolved
Hide resolved
16 tasks
…ructor - Modified constructor to require displayOnCreate parameter - Updated all constructor calls to pass the correct displayOnCreate value
This comment has been minimized.
This comment has been minimized.
- Update displayOnCreate handling in MetadataBlockServiceBean - Refactor predicates for better input level handling - Add default value handling for displayOnCreate - Update service methods to consider input level configuration
- Add displayOnCreate check method in Dataverse - Update displayOnCreate handling in DatasetPage - Add save method for input levels in service - Update template handling for displayOnCreate - Improve code formatting
Please address the merge conflicts along with the review comments. Thanks |
stevenwinship
approved these changes
Feb 21, 2025
This PR has a merge conflict. |
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
@stevenwinship @ofahimIQSS I have added all the adjustments and the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
FY25 Sprint 16
FY25 Sprint 16 (2025-01-29 - 2025-02-12)
FY25 Sprint 17
FY25 Sprint 17 (2025-02-12 - 2025-02-26)
NIH CAFE
Issues related to and/or funded by the NIH CAFE project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces the
displayOnCreate
property to theDataverseFieldTypeInputLevel
class, allowing administrators to configure metadata fields to appear during dataset creation, even if they are not required.Previously, metadata fields selected for a collection would only appear during dataset creation if they were marked as required (or displayOnCreate by default). This change grants collection administrators control over metadata visibility, improving metadata completeness and discoverability.
Which issue(s) this PR closes:
Special notes for your reviewer:
This PR implements the functionality for
displayOnCreate
, but the UI implementation is not included yet.The implementation includes:
displayOnCreate
inDataverseFieldTypeInputLevel
Testing via API:
Automated Tests:
Run the integration test:
mvn test -Dtest=DataversesIT#testUpdateInputLevelDisplayOnCreate
Does this PR introduce a user interface change?:
No UI changes in this PR. A separate issue will track the UI implementation.
Additional documentation: