11188 API to get list of dataset versions with summary of differences #11247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
added
Size: 3
g-saracca
added
GREI Re-arch
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
stevenwinship
requested changes
Feb 21, 2025
| <h:outputText rendered="#{blockNote.added > 0}" value="#{blockNote.added} #{bundle['file.dataFilesTab.versions.added']}" /> | ||
| <h:outputText rendered="#{(blockNote.added) > 0 and (blockNote.changed + blockNote.deleted) > 0}" value=", " /> | ||
| <h:outputText rendered="#{(blockNote.deleted) > 0}" value="#{blockNote.deleted} #{bundle['file.dataFilesTab.versions.removed']}" /> | ||
| <h:outputText rendered="#{(blockNote.changed) > 0 and (blockNote.changed) > 0}" value=", " /> |
There was a problem hiding this comment.
should this be
(blockNote.deleted) > 0 and (blockNote.changed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: For the SPA we need an api that returns a list of Dataset Versions for the Versions Tab. The versions tab also shows a summary of differences between consecutive versions when available so that is returned as part of the response.
Which issue(s) this PR closes:
Special notes for your reviewer: As per request of Ellen, the Dataset Field type names and Metadata block names are in display name format. The DatasetsIT#testCompareDatasetVersionsAPI is failing - not sure why it shouldn't have been changed in my branch, but the order of two metadata field is reversed.
Suggestions on how to test this: Try the api for a dataset with multiple versions and see that the response gives the info required to load into the versions tab of the dataset page. If there's a draft version use tokens with and without view unpublished permissions.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: included
Additional documentation: added to the native api doc