feat: Accessibility for project detail page and file browser #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidverdu
commented
Jun 23, 2025
Comment on lines
+5
to
+23
| <nav aria-label="<%= t('.nav_file_browser_label') %>"> | ||
| <ol data-file-browser-target="pathDisplay" class="breadcrumb d-flex align-items-center flex-wrap gap-2"> | ||
| <% path_parts = current_path.split('/').reject(&:blank?) %> | ||
| <% accumulated_path = '/' %> | ||
| <% path_parts.each do |part| %> | ||
| <li> | ||
| <% accumulated_path = File.join(accumulated_path, part) %> | ||
| <span class="text-muted">/</span> | ||
| <a class="breadcrumb-folder text-body text-decoration-none" | ||
| tabindex="0" | ||
| data-entry-path="<%= accumulated_path %>" | ||
| data-entry-type="folder" | ||
| data-action="dblclick->file-browser#handleDoubleClick keydown->file-browser#handleKeydown"> | ||
| <i class="bi bi-folder-fill" aria-hidden="true"></i> <%= part %> | ||
| </a> | ||
| </li> | ||
| <% end %> | ||
| </ol> | ||
| </nav> |
There was a problem hiding this comment.
path browser redefined as a ul list with li items inside a nav tag, to make it more understandable for accessibility devices. tabindex="0" and the keydown handler in data-action allow the usage of keyboard
davidverdu
commented
Jun 23, 2025
Comment on lines
+96
to
+97
| tabindex="0" | ||
| data-action="dragstart->file-browser#handleDragStart dragend->file-browser#handleDragEnd dblclick->file-browser#handleDoubleClick keydown->file-browser#handleKeydown"> |
There was a problem hiding this comment.
these lines allow the use of keyboard
abujeda
reviewed
Jun 25, 2025
| @@ -11,7 +11,7 @@ | |||
| <%= t('.file_drop_text') %> | |||
| </div> | |||
| <div data-file-drop-target="icon" class="position-absolute translate-middle-y drop-text d-none" style="top: 50%; left: 1rem; z-index: 100;"> | |||
| <i class="bi bi-plus-square-fill fs-1"></i> | |||
| <i class="bi bi-plus-square-fill fs-1" aria-hidden="true"></i> | |||
| </div> | |||
There was a problem hiding this comment.
Don't we need a title or hidden span here?
abujeda
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #155